warning non void function does not return a value

The variable 'X' is being used for this loop and for the outer loop. V641. V3109. Every switch-clause should be terminated by an unconditional 'break' or 'throw' statement. Possibly an incorrect HTML. It is not recommended to return null or throw exceptions from 'toString' / 'clone' methods. It may happen that flow is never reaching that part of the code but it is important to write for the compiler. The code fragment is equivalent to the following: Note that undefined behavior occurs only if the end of a non-void function is actually reached. Property setter / event accessor does not utilize its 'value' parameter. Implementation of 'compareTo' overloads the method from a base class. V3517. V613. V3096. It is odd that the body of 'Foo_1' function is fully equivalent to the body of 'Foo_2' function. Every 'switch' statement should contain non-empty switch-clauses. The expression is excessive or contains a logical error. Potentially tainted data is used in the path toextractthe file. It is possible that a typo is present inside the expression. This is the same thing that happens at the end of the function anyway. V3062. The '&' or '|' operator is applied to bool type value. V664. V2610. V3511. Syntax: return[expression]; There are various ways to use return statements. The size of the dynamic array can be less than the number of elements in the initializer. V6076. V2012. V597. The result should possibly be saved to a temporary variable, which then could be used while calling the 'B' function. V6102. V6080. The 'delete' operator is applied to non-pointer. Consider naming the object. V678. Consider checking the first actual argument of the 'Foo' method. The result of '&' operator is '0' because one of the operands is '0'. Probably meant: '\xNN'. Upgrade to Microsoft Edge to take advantage of the latest features, security updates, and technical support. V2518. V631. Every 'switch' statement should have a 'default' label, which, in addition to the terminating 'break' statement, should contain either a statement or a comment. See documentation for details. Any label should be declared in the same block as 'goto' statement or in any block enclosing it. Unchecked tainted data is used in expression. When we call a function in a context that requires a value (e.g. Consider inspecting the expression. V3530. Three potential reasons for issue the warning (elevated to an error) in spite of this come to mind: Nonetheless, this is easy to work around. Function returns a pointer to the internal string buffer of a local object, which will be destroyed. Call 'Dispose' when disposing 'A' class. V6100. If the function has a void return type, this behavior is okay, but may be considered poor style. Extracting arguments from a list of function calls. V1033. AUTOSAR. OWASP. The other function parameter expects a file path instead. Consider inspecting the expression. Implicit type conversion from memsize type to 32-bit type. V3146. V795. MISRA. V543. When main calls printHi, the code in printHi executes, and Hi is printed. Possible incorrect initialization of variable. Overflow check is incorrect. The 'strlen' function was called multiple times inside the body of a loop. V2002. Features from should not be used. This pattern is suspicious. He also rips off an arm to use as a sword. V3017. V6027. Consider making the project fully compilable and building it before analysis. Suspicious pointer arithmetic. The value of uninitialized variable should not be used. Unchecked tainted data is used in expression. It's odd that this method always returns one and the same value of NN. V2584. That's because exit is marked as [[noreturn]]. V001. V669. Here's the correct version: The 'main' and 'wmain' functions are the exceptions. MISRA. Functions should not be declared at block scope. When a return statement contains an expression in functions that have a void return type, the compiler generates a warning, and the expression isn't evaluated. Unbounded functions performing string operations should not be used. Email? EOF should not be compared with a value of the 'char' type. V6056. OWASP. Use of two opposite conditions. V6017. Usage of potentially invalid handle. Temporary object is created and then destroyed. V2524. Probably meant: (T1)((T2)a + b). V1002. You can return a value from a Function procedure in any of the following ways: Assign the value to the Function procedure name and then perform an Exit Function statement. nlohmann/json.hpp:20017:5: warning: non-void function does not return a value in all control paths [-Wreturn-type], reference operator[](T* key) The 'Thread' object is created but is not started. This variable is passed by reference to the 'Foo' function in which its value will be used. The language standard does not define order in which 'Foo' functions are called during evaluation of arguments. Operands of the logical '&&' or the '||' operators, the '!' V3156. V520. The right operand is greater than or equal to the number of bits in the left operand. Memory allocation and deallocation functions should not be used. V6011. Inconsistent synchronization of a field. rev2023.4.21.43403. V6067. After each of these function calls, execution continues at the next statement. V3121. Presence of #line directives may cause some diagnostic messages to have incorrect file name and line number. Using this sequence lead to undefined behavior. The class implements a copy constructor/operator=, but lacks the operator=/copy constructor. Looking at the assembly GCC 11.2 generates for this with -O3, we see it has in fact recognized that the union of all cases in the if and else if covers all possibilities: It has generated only two code paths, not three. The initial value of the index in the nested loop equals 'i'. The 'throw' keyword could be missing. V2010. Use the RtlSecureZeroMemory() function to erase private data. What is the Russian word for the color "teal"? If function ends without return (or throw), then the behaviour of the program will be undefined. Multiple copies of it will be created in all translation units that include this header file. The 'x' variable is assigned to itself. MISRA. Uninitialized variables are used when initializing the 'A' variable. It achieves the same as what you have but it only will add a line instead of modifying the whole function body, and it will be one allocation less ( int val = 0; ). To subscribe to this RSS feed, copy and paste this URL into your RSS reader. By clicking Accept all cookies, you agree Stack Exchange can store cookies on your device and disclose information in accordance with our Cookie Policy. V724. Suspicious explicit conversion from 'float *' type to 'double *' type. Argument of abs() function is minimal negative value. Functions should be declared in prototype form with named parameters. Is the code I've written here adequate to do that? An empty exception handler. OWASP. It's possible that the line was commented out improperly, thus altering the program's operation logics. V728. Consider inspecting it for a possible error. V623. Some diagnostic messages may contain incorrect line number. MISRA. I am getting this error when trying to compile the below code. You are assuming that loop will always run, but, what if an empty string ends up getting submitted? Expressions with enum underlying type should have values corresponding to the enumerators of the enumeration. Let's consider an example. V3526. Copying from potentially tainted data source. V503. V529. Size of an array is not specified. V2551. Check lines: N1, N2. V3142. V596. V738. :' operator has a lower priority than the 'foo' operator. V746. V3005. If a return value isn't required, declare the function to have void return type. V2526. V008. Sorting keys priority will be reversed relative to the order of 'OrderBy' method calls. Initial and final values of the iterator are the same. The initial value of the index in the nested loop equals 'i'. Value from the uninitialized optional is used. An odd precise comparison. The constant NN is being utilized. V731. Possible command injection. Inspect the following programs and state what they output, or whether they will not compile. V303. Passing cheap-to-copy argument by reference may lead to decreased performance. V2528. V793. Casting potential 'null' value to a value type can lead to NullReferenceException. V5007. V3117. Probably the '+=' should be used here. A compatible declaration should be visible when an object or function with external linkage is defined. V743. Consider inspecting the expression. The compiler has been asked to warn when a function has a control path that doesn't return a value (although not mentioned in the message, throwing a value and possibly calling a non-returning function may also be considered acceptable). Check lines: N1, N2. Making statements based on opinion; back them up with references or personal experience. It is possible that 'else' block was forgotten or commented out, thus altering the program's operation logics. V593. The functions from time.h/ctime should not be used. Unsafe invocation of event, NullReferenceException is possible. Early returns can be used in value-returning functions too: First, print() is called. In this case, the return value of the called function is undefined. It is possible that ',' comma is missing at the end of the string. The '\0xNN' characters were encountered. V3113. V2567. V3135. 'else' keyword is probably missing. Consider checking the Nth actual argument of the 'Foo' function. Then the return statement is executed, returning the value of 5 back to the caller. V819. Explicit conversion from 32-bit integer type to memsize type. The value range of the variable: [A, B]. We and our partners use data for Personalised ads and content, ad and content measurement, audience insights and product development. V3133. V5615. The function is used as if it returned a bool type. V113. Consider inspecting signed and unsigned function arguments. Consider inspecting the application's logic. To learn more, see our tips on writing great answers. There should be no implicit integral-floating conversion. Variable 'foo' was assigned the same value. V2554. and '.' There is no point to declare constant reference to a number. It is possible that a typo is present inside the expression. V771. Exception is of the 'int' type because NULL is defined as 0. V835. Consider inspecting the expression. MISRA. Consider using the KK constant. Consider checking the use of this variable. V3006. V660. V6064. The expression contains a suspicious mix of integer and real types. AUTOSAR. Cyclomatic complexity: NN. Temporary object is immediately destroyed after being created. Pointer to an object of the class is cast to unrelated class. Well occasionally send you account related emails. If you are treating warnings as errors, you may need to temporary disable that setting in order to compile the example. Passing the value into the 'Foo' method will result in an exception. The 'foo' word is suspicious. This leads to the variable binding to a temporary object instead of a range element. V3079. It causes the function to return to the caller immediately. Function 'Foo' writes/reads 'N' bytes. V762. V661. Decreased performance. Possible log injection. Unsafe synchronization on an object. Value of a composite expression should not be cast to a different essential type category or a wider essential type. Suspicious subexpression in a sequence of similar comparisons. MISRA. V5601. V5001. Reference was invalidated because of destruction of the temporary object returned by the function. Consider reviewing the correctness of 'X' item's usage. MISRA. Value of variable is checked after use. AUTOSAR. V3104. Possible server-side request forgery. The expression is incorrect or it can be simplified. The operation is executed 2 or more times in succession. V1034. V2516. Appending an element and checking for key uniqueness is performed on two different variables. A pointer/reference parameter in a function should be declared as pointer/reference to const if the corresponding object was not modified. Recurring sequence of explicit type casts. Consider using the extended version of the 'foo' function here. Recurring check. An odd sequence of assignments of this kind: A = B; B = A; V3038. Asking for help, clarification, or responding to other answers. See NN argument of function 'Foo' in derived class and base class. Compiler may delete 'memset' function call that is used to clear 'Foo' buffer. This may lead to ODR violation. OWASP. AUTOSAR. V3539. Suspicious pointer arithmetic with 'malloc/new'. String is printed into itself. It is possible that a typo is present inside the string literal. The value of a composite expression should not be assigned to an object with wider essential type. Pointer was used in the logical expression before its check for nullptr in the same logical expression. IDisposable object is not disposed before method returns. Consider inspecting usage of 'Y' counter. V807. Did the drapes in old theatres actually say "ASBESTOS" on them? Consider utilizing an explicit type cast to avoid the loss of a fractional part. By clicking Accept all cookies, you agree Stack Exchange can store cookies on your device and disclose information in accordance with our Cookie Policy. AUTOSAR. Dangerous construction is used: 'm[x] = m.size()', where 'm' is of 'T' class. OWASP. V3169. However, this statement is trying to send the return value of printHi to std::cout to be printed. The standard signal handling functions should not be used. Pointer to local array 'X' is stored outside the scope of this array. In lieu of a data type, void functions use the keyword "void." A void function performs a task, and then control returns back to the caller--but, it does not return a value. Why did US v. Assange skip the court of appeal? V3166. Expression used in condition should have essential Boolean type. MISRA. AUTOSAR. triniChillibibi 2 yr. ago This was for my print_winner function in runoff. Congratulations! V3139. Initial and final values of the iterator are the same. Unconditional 'break/continue/return/goto' within a loop. It is suspicious that the value 'X' of HRESULT type is compared with 'Y'. In such a case, the comparison operation can potentially behave unexpectedly. Use volatile variable(s) or synchronization primitives to avoid this. V1052. Variables are initialized through the call to the same function. AUTOSAR. When compiling the above example, your compiler may issue a warning about line 9 being unreachable. V708. V6057. MISRA. The function with the 'abort/exit/getenv/system' name should not be used. V221. This condition was already verified in previous line. MISRA. V825. The square function returns the square of its argument, in a wider type to prevent an arithmetic error. V3540. V657. Consider inspecting the function. V665. V3177. V645. As your code stands, if candidate_count is greater than 0 the loop will iterate once and then unconditionally return false, which I don't think is what you want. Was Aristarchus the first to propose heliocentrism? Sign in OWASP. V120. Pointer is dereferenced on the initialization list before its check for null inside the body of a constructor function. Find centralized, trusted content and collaborate around the technologies you use most. V612. V794. So far, we never make a pedantic check with exceptions switched off. V1093. V2594. V3528. This is your promo code! Inspect the program's logic. Save the file, and compile it in a Developer command prompt window by using the command: Then, to run the example code, enter C_return_statement.exe at the command prompt. Do not use old versions of SSL/TLS protocols as it may cause security issues. Since the function doesnt return a value, this is fine. V2531. The expression of strlen(MyStr.c_str()) kind can be rewritten as MyStr.length(). V3512. Code contains collection of similar blocks. V732. The virtual destructor is not present, although the 'Foo' class contains virtual functions. The 'goto' statement should not be used. The 'bar2.h' header will be excluded from compilation. AUTOSAR. V779. Suspicious assignment inside the conditional expression of 'if/while/for' statement. It is possible that an error is present. A return statement ends the execution of a function, and returns control to the calling function. Violated order of exception handlers. Part of conditional expression is always true/false. Your function should return a vector in every possible condition. V2607. V2598. :' operator may not work as expected. Unreachable code detected. If no return expression is supplied, the Microsoft C runtime returns a value that indicates success (0) or failure (a non-zero value). Then main returns a value of 0 (typically used to report success) to end the program. Consider inspecting the expression. Functions should not have unused parameters. The 'malloc' function allocates suspicious amount of memory calculated by 'strlen(expr)'. V3189. We discuss the debate over early returns in lesson 7.10 -- Break and continue. Function '' doesn't return a value on all code paths. Loop break conditions do not depend on the number of iterations. The 'SysFreeString' function should be called only for objects of the 'BSTR' type. V010. A value of variable is not modified. V2537. V3510. V633. MISRA. Class member is initialized with dangling reference. Custom declaration of standard type. Continue with Recommended Cookies. Use _beginthreadex/_endthreadex functions instead of CreateThread/ExitThread functions. It is suspicious that the argument of sizeof() operator is the expression. The 'throw' keyword could be missing. Here is my code: why does it show compile error?? An exception handling block does not contain any code. V6024. Function receives suspicious argument. Possibly meant: 'A -= B'. Bit shifting of the 32-bit value with a subsequent expansion to the 64-bit type. Empty exception handler. V684. The '? V697. V777. Stack of original exception could be lost. Consider using the declaration from system header files instead. MISRA. V3023. Function execution could be deferred. Maximum size of a vector is known at compile time. Incorrect type of a loop variable. V6053. Type implementing IEquatable interface does not override 'GetHashCode' method. Uninitialized class member is used to initialize another member. By cv void, it simply means a function with void return type, that may be const or volatile. V1028. AUTOSAR. V544. WPF: several Dependency Properties are registered with a same name within the owner type. Any label should be declared in the same block as 'goto' statement or in any block enclosing it. V1035. Learn more about Stack Overflow the company, and our products. Class defines a custom new or delete operator. MISRA. Consider inspecting the function call. V6075. Assign the value to the Function procedure name and then perform the End Function statement. Its representation is implementation-defined. Pointer was used after the memory was released. V2619. V2552. V690. V3178. (i have tried it with just else instead of else if and get same error). The left operand of integer division is less than the right one. It is suspicious that the result of the statement is a part of the condition. MISRA. The return value of non-void function should be used. The pointer is cast to an integer type of a larger size. Perhaps, this is a typo and 'X' variable should be used instead of 'Y'. V706. V1082. Then the ',' operator returns a resulting value from the right side of the expression. Possible LDAP injection. Site design / logo 2023 Stack Exchange Inc; user contributions licensed under CC BY-SA. A component of TimeSpan is used, which does not represent full time interval. AUTOSAR. hi, at least for bool keyPressed(ofKeyEventArgs& args) it should return false as the default otherwise the event propagation will stop.. in glTypeForImageType(int imageType)I would simply add return 0; at the end of the function. V511. The 'operator &&', 'operator ||', 'operator ,' and the unary 'operator &' should not be overloaded. V3015. Inappropriate attempt to append a null character to a string. Explicit conversion from 'void *' to 'int *'. V3003. If you haven't received our response, please do the following: check your Spam/Junk folder and click the OWASP. Implicitly specified enumeration constants should be unique consider specifying non-unique constants explicitly. By clicking Post Your Answer, you agree to our terms of service, privacy policy and cookie policy. Return value is not always used. The 'delete A, B' expression only destroys the 'A' object. Two or more case-branches perform the same actions. V6066. Use direct analyzer integration or compiler monitoring instead. V2590. One of the operands in the operation equals NN. V517. AUTOSAR. V628. V813. Consider inspecting the expression. V124. V2571. The 'goto' statement shouldn't jump to a label declared earlier. check your Spam/Junk folder and click the "Not Spam" button for our message. V3058. The 'alloca' function is used inside the loop. Examine the substrings "abc" and "abcd". V3518. V1024. Expressions with enum underlying type should have values corresponding to the enumerators of the enumeration. V775. MISRA. V013. This will cause the loss of the higher bits. V703. Suspicious assignment inside the condition expression of 'if/while/for' operator. Consider inspecting the expression. V809. Consider inspecting the expression. V1025. V1078. V552. Check for typos. How to force Mathematica to return `NumericQ` as True when aplied to some variable in Mathematica? V2527. V814. If you cant find an answer to your question, fill in the form below and our developers will contact you. MISRA. V821. V694. Update: You need to make your function return a vector in every condition as suggested in comments. V717. Be advised that the size of the type 'long' varies between LLP64/LP64 data models. V3151. Integer constant is converted to pointer. V764. Function should not be declared implicitly. V1069. To view the purposes they believe they have legitimate interest for, or to object to this data processing use the vendor list link below. V3172. The '? Suspicious function declaration. Dangerous cast of 'this' to 'void*' type in the 'Base' class, as it is followed by a subsequent cast to 'Class' type. How to Make a Black glass pass light through it? V833. AUTOSAR. It is more efficient to search for 'X' character rather than a string. V6071. Variable of the 'string_view' type references a temporary object, which will be removed after evaluation of an expression.
Jeff Thompson Dominique Dawes, Red Land High School Football Roster, Female Lobsters Vs Male Lobsters Boiling Water, Convert Bearings To Azimuths Calculator, Advantages And Disadvantages Of Visual Research Methods, Articles W

warning non void function does not return a value 2023